Skip to content
This repository was archived by the owner on Mar 1, 2022. It is now read-only.

Upgrade gcloud dependency to google-cloud 0.19.x#101

Closed
bjwatson wants to merge 4 commits intogoogleapis:masterfrom
bjwatson:change-gcloud-imports
Closed

Upgrade gcloud dependency to google-cloud 0.19.x#101
bjwatson wants to merge 4 commits intogoogleapis:masterfrom
bjwatson:change-gcloud-imports

Conversation

@bjwatson
Copy link
Copy Markdown
Contributor

@bjwatson bjwatson commented Sep 22, 2016

Fixes #103 and #102.

Comment thread requirements.txt
oslo.utils>=3.4.0 # Apache-2.0
pyyaml>=3.11
taskflow==1.25.0
taskflow>=1.25.0,<2.0.0

This comment was marked as spam.

@bjwatson
Copy link
Copy Markdown
Contributor Author

bjwatson commented Sep 22, 2016

Apparently #100 was not as low-risk as I thought. Getting review on this one, but we should it quickly since I broke master.

Never mind. This is more involved than I thought. I reverted the offending change from master, so the urgency is somewhat reduced.

There's still a version conflict in the self-service instructions that originally motivated what I was doing here.

@bjwatson bjwatson changed the title Fix imports broken by gcloud rename Upgrade gcloud dependency to google-cloud 0.19.x Sep 22, 2016
@shinfan
Copy link
Copy Markdown
Contributor

shinfan commented Sep 22, 2016

Travis seems cannot import "google.cloud". Is this module name incorrect?

@geigerj
Copy link
Copy Markdown
Contributor

geigerj commented Sep 22, 2016

@shinfan what's especially strange is that the import error only happens in the pylint environment, not pep8 or py27...

@geigerj
Copy link
Copy Markdown
Contributor

geigerj commented Sep 22, 2016

@shinfan From the Travis log:

pylint-errors installed:...
...google-cloud==0.19.0...

So google-cloud should be installed available in the pylint-errors environment. And

$ virtualenv venv
$ . venv/bin/activate
(venv) $ pip install google-cloud==0.19.0
  ...
(venv) $ python
Python 2.7.12 (default, Aug 24 2016, 08:19:55) 
[GCC 4.8.4] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.cloud
>>>

So the module google.cloud name seems OK.

@shinfan
Copy link
Copy Markdown
Contributor

shinfan commented Sep 22, 2016

Umm this is strange...Can you reproduce the issue locally?

@lukesneeringer
Copy link
Copy Markdown
Contributor

This is way out of date at this point. Declaring it dead.

saicheems pushed a commit to saicheems/artman that referenced this pull request Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants