docs(AIP-158): clarify response plural first docs#1571
Conversation
Summary of ChangesHello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the accuracy of the documentation for the AIP-158 rule concerning paginated methods. It clarifies that the rule applies to any response message that includes a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request clarifies the documentation for the response-plural-first-field rule (AIP-158). The changes accurately reflect that the rule applies to any paginated response message (identified by the presence of next_page_token), not just those from List or Search methods. This improves the documentation's accuracy and clarity. I have one minor suggestion to fix a typo.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
The rule has, since its inception, linted every response message containing a
next_page_tokenfield b.c that is reserved for the AIP-158 Pagination design pattern.Closes #986 by fixing the broken docs, not changing the scope of the rule.