Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Java: regenerating - updating resource name types#432

Merged
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:master
Nov 6, 2017
Merged

Java: regenerating - updating resource name types#432
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

Also trimming api-common dependencies using googleapis/gapic-generator#1669 .

@pongad
Copy link
Copy Markdown
Contributor

pongad commented Nov 6, 2017

The changes look fine.
I might be missing something, but why do we check in proto files in this repo?

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor Author

So we can see the diffs, and also we call "./gradlew uploadArchives" from this repo locally, so it's nice to have a commit for each release we do.

@pongad
Copy link
Copy Markdown
Contributor

pongad commented Nov 6, 2017

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit 0476c48 into googleapis:master Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants