Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

java: update build.gradle and add video-intelligence#361

Merged
pongad merged 1 commit intogoogleapis:masterfrom
pongad:grpc1.4
Jun 26, 2017
Merged

java: update build.gradle and add video-intelligence#361
pongad merged 1 commit intogoogleapis:masterfrom
pongad:grpc1.4

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Jun 23, 2017

The build.gradle change reflects googleapis/gapic-generator#1382.

Generated Code:
Dependency changes are described in googleapis/google-cloud-java#2171

Changes to Java code

The rest are changes to generated protobuf classes introduced by updating protoc to v3.3.0

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jun 23, 2017

Java CI is failing because we need to update gax dependency, but we should merge this so I can release new protos, which is required for updating gax.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

There is an enormous number of changes included in this PR. Is there any way to split things up, or at least give an overview in the description of what kind of changes this includes?

@pongad
Copy link
Copy Markdown
Contributor Author

pongad commented Jun 23, 2017

@garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM

@pongad pongad merged commit 9c8fece into googleapis:master Jun 26, 2017
@pongad pongad deleted the grpc1.4 branch June 26, 2017 04:16
pongad added a commit that referenced this pull request Jun 26, 2017
gax dependency is updated to 1.4.1, following googleapis/gax-java#332.

google-longrunning-v1 now has its own build.gradle,
since its dependencies were removed
and inadvertently not replaced
in #361.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants