Fix cuda build with Bzlmod#84
Merged
yuriivcs merged 1 commit intogoogle-ml-infra:mainfrom Sep 26, 2025
Merged
Conversation
Contributor
Author
|
@yuriivcs I tried to run the test on my machine with It builds correctly, but running failed with This also happens to the workspace build, I guess I'm missing cuda installation on my machine? |
This was referenced Sep 19, 2025
Contributor
Author
|
Looks like what I need is But the test still fails with for both workspace and bzlmod build. Overall, I think the build works, but maybe my local setup is still not correct for running the test |
Contributor
Author
github-merge-queue Bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 23, 2025
This new attribute contains the original value of the `name` attribute at the instantiation site of the repo rule (e.g., `rctx.original_name` would be `foo` if `rctx.name` is `+ext+foo`). Fixes #24467 Closes #25121. RELNOTES: Added `repository_ctx.original_name`, which contains the original value of the `name` attribute as specified at the repo rule call site. PiperOrigin-RevId: 722731393 Change-Id: I2f7dada0c44b6bd4c0d2622fa1e97223382a8547 (cherry picked from commit 8bcfb06) Fixes #27033 Context: this would help google-ml-infra/rules_ml_toolchain#84 --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
Collaborator
|
I haven't been able to fix this issue yet, will do it next week. |
Contributor
Author
|
@yuriivcs Since the issue is irrelevant to this PR, can we merge this first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Bzlmod,
repository_ctx.namereturns the canonical repo name, but we need the original repo name used for checking cuda libraries.Also added missing environ for _redist_repo