Skip to content

Drop chai and mocha deps #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethvargo merged 1 commit into from
Nov 15, 2023
Merged

Drop chai and mocha deps #342

sethvargo merged 1 commit into from
Nov 15, 2023

Conversation

@sethvargo
Copy link
Contributor

@sethvargo sethvargo commented Nov 15, 2023

No description provided.

@sethvargo sethvargo requested a review from a team as a code owner November 15, 2023 01:21
@sethvargo sethvargo enabled auto-merge (squash) November 15, 2023 01:25
verbanicm
verbanicm approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@verbanicm verbanicm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so much cleaner

@sethvargo sethvargo merged commit 04900d1 into main Nov 15, 2023
@sethvargo sethvargo deleted the sethvargo/deps branch November 15, 2023 13:33
@google-github-actions-bot google-github-actions-bot mentioned this pull request Nov 20, 2023
Merged
sethvargo pushed a commit that referenced this pull request Nov 20, 2023
@google-github-actions-bot
Release: v1.2.0 (#346)
f105ef0 
## What's Changed
* Update deps by @sethvargo in
#312
* dependabot: only do security updates by @sethvargo in
#320
* update all deps by @sethvargo in
#321
* Update README.md by @mattseymour in
#332
* Update deps to Node 20 by @sethvargo in
#339
* Drop chai and mocha deps by @sethvargo in
#342
* Switch to more resilient testing by @sethvargo in
#343
* Build latest versions by @sethvargo in
#345

## New Contributors
* @mattseymour made their first contribution in
#332

**Full Changelog**:
v1.1.1...cf96593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verbanicm verbanicm verbanicm approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sethvargo @verbanicm