feat: support proxy for outgoing traffic#217
feat: support proxy for outgoing traffic#217juldanherglo wants to merge 1 commit intogoogle-github-actions:mainfrom 7Learnings:main
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
We are standardizing on actions/http-client because that's what GitHub recommends for proxy settings on self-hosted runners (https://docs.github.com/en/actions/hosting-your-own-runners/using-a-proxy-server-with-self-hosted-runners). I added support in #218. |
Thank you, @sethvargo . I tested #218 and it works as well. There was one warning though: |
I have the requirement that our selfhosted gitlab-runners need to use a proxy for outgoing traffic. This solved the problem.
Is that something that you would consider in a PR? Or do you maybe even have a better solutions?