Skip to content

feat: support proxy for outgoing traffic#217

Closed
juldanherglo wants to merge 1 commit intogoogle-github-actions:mainfrom
7Learnings:main
Closed

feat: support proxy for outgoing traffic#217
juldanherglo wants to merge 1 commit intogoogle-github-actions:mainfrom
7Learnings:main

Conversation

@juldanherglo
Copy link
Copy Markdown

I have the requirement that our selfhosted gitlab-runners need to use a proxy for outgoing traffic. This solved the problem.

Is that something that you would consider in a PR? Or do you maybe even have a better solutions?

@juldanherglo juldanherglo requested a review from a team as a code owner August 30, 2022 12:18
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Aug 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sethvargo sethvargo mentioned this pull request Aug 30, 2022
@sethvargo
Copy link
Copy Markdown
Contributor

Hi @juldanherglo

We are standardizing on actions/http-client because that's what GitHub recommends for proxy settings on self-hosted runners (https://docs.github.com/en/actions/hosting-your-own-runners/using-a-proxy-server-with-self-hosted-runners). I added support in #218.

@juldanherglo
Copy link
Copy Markdown
Author

Hi @juldanherglo

We are standardizing on actions/http-client because that's what GitHub recommends for proxy settings on self-hosted runners (https://docs.github.com/en/actions/hosting-your-own-runners/using-a-proxy-server-with-self-hosted-runners). I added support in #218.

Thank you, @sethvargo . I tested #218 and it works as well. There was one warning though:

(node:18684) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants