fix(ide): increase IDE open / close tool timeouts#8587
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @skeshive, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the stability and user experience of the IDE connection. It addresses potential issues with long-running operations by increasing timeouts, improves connection reliability through more frequent keep-alive signals, and provides clearer feedback to users when connection problems occur, ultimately leading to a more robust and user-friendly IDE integration.
Highlights
- Increased IDE Tool Call Timeouts: The timeout for long-running IDE operations, specifically
openDiffandcloseDiff, has been extended to 10 minutes. This change prevents errors when dealing with large files that require more time to process diffs. - More Frequent Keep-Alive Pings: The VS Code IDE companion server now sends keep-alive pings every 30 seconds, down from 60 seconds, to maintain a more robust connection.
- Enhanced Connection Error Messages: User-facing error and disconnection messages related to the IDE connection have been made more specific and helpful for troubleshooting purposes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively improves the robustness of the IDE connection by increasing timeouts for long-running operations and making keep-alive pings more frequent. The refactoring to use the client.request method simplifies the code in ide-client.ts and the updated connection messages provide better user feedback. I have a couple of suggestions to further improve maintainability and error handling robustness.
|
Size Change: +3 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
…outs (google-gemini#8587) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
TLDR
This PR improves the robustness of the IDE connection by increasing the timeout for long-running operations (like opening a diff) to 10 minutes and making the connection keep-alive more frequent. It also provides clearer feedback to the user when the IDE connection is lost.
Dive Deeper
The key changes are:
openDiffandcloseDiff, now have a 10-minute timeout. This prevents errors when working with large files that take a while to open the diff for.Linked issues / bugs
Fixes #8365