Skip to content

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Dec 27, 2025

Summary

This PR fixes a workflow failure in gemini-scheduled-issue-dedup.yml by removing an unsupported configuration key (enabled) from the mcpServers settings. This is an urgent fix to restore the scheduled issue deduplication process.

Details

The investigation revealed that:

  1. The MCPServerConfig class in packages/core/src/config/config.ts has never defined an enabled property since its creation.
  2. Previously, the Gemini CLI leniently ignored unknown keys in settings.json.
  3. Commit 5062fad (chore: autogenerate settings documentation (chore: autogenerate settings documentation #12451)) introduced strict schema validation using Zod with additionalProperties: false for MCPServerConfig.
  4. This change caused the CLI to throw an "Unrecognized key(s) in object: 'enabled'" error, leading to workflow termination.

The fix involves simply removing the "enabled": true line from the workflow's settings string, aligning it with the current schema.

Related Issues

Fixes #15610

How to Validate

  1. Inspect .github/workflows/gemini-scheduled-issue-dedup.yml to ensure "enabled": true is removed from mcpServers.issue_deduplication.
  2. (Optional) Run the CLI locally with a settings.json containing the same mcpServers configuration to verify it no longer throws validation errors.
  3. Verify that telemetry.enabled is still present, as it is a valid key for that section.

Pre-Merge Checklist

  • Updated relevant documentation and README (N/A)
  • Added/updated tests (N/A - workflow fix)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@Han5991 Han5991 requested a review from a team as a code owner December 27, 2025 05:05
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@gemini-cli gemini-cli bot added the area/non-interactive Issues related to GitHub Actions, SDK, 3P Integrations, Shell Scripting, Command line automation label Jan 7, 2026
@scidomino
Copy link
Collaborator

I approve this change but I noticed a similar error in gemini-automated-issue-dedup.yml so I will add that to this PR.

@scidomino scidomino added this pull request to the merge queue Jan 8, 2026
Merged via the queue into google-gemini:main with commit e51f3e1 Jan 8, 2026
26 checks passed
sumansaurabh pushed a commit to sumansaurabh/gemini-cli that referenced this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/non-interactive Issues related to GitHub Actions, SDK, 3P Integrations, Shell Scripting, Command line automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Workflow failure in gemini-scheduled-issue-dedup due to invalid config key 'enabled'

3 participants