fix(client): Correctly latch hasFailedCompressionAttempt flag #13002
Conversation
The `hasFailedCompressionAttempt` flag is intended to prevent the client from wastefully retrying automatic (non-forced) compression after it has already failed once with an inflated token count. The previous logic (`this.hasFailedCompressionAttempt = !force && true;`) incorrectly reset this flag to `false` if a subsequent *forced* compression attempt also failed. This commit modifies the condition to only set the flag to `true` on a *non-forced* failure (`&& !force`). This ensures the flag latches correctly for the remainder of the session as intended, preventing inefficient retries and token usage.
Summary of ChangesHello @pareshjoshij, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the client's compression mechanism where a critical flag, intended to prevent repeated failed compression attempts, was being incorrectly reset. The fix ensures that this flag maintains its state as intended, leading to more efficient operation by avoiding unnecessary retries after an initial compression failure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where the hasFailedCompressionAttempt flag was being improperly reset. The new logic ensures the flag latches correctly after a non-forced compression failure, preventing wasteful retries. The change is clear and effective. While the logic is sound, the pull request would be strengthened by including a unit test that explicitly verifies this fix, as mentioned in my detailed comment.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request addresses a logic bug where the hasFailedCompressionAttempt flag was incorrectly reset during a forced compression attempt. The change correctly modifies the logic to ensure the flag, once set to true by a non-forced failure, remains latched for the rest of the session. A new, focused unit test has been added that effectively validates this corrected latching behavior. The fix is clean, the reasoning is sound, and the changes look good.
|
Hi @scidomino, I noticed you have been active on recent PRs, so I wanted to bring this to your attention. This PR (#13002) fixes the hasFailedCompressionAttempt latching bug (#13058) and now includes the specific unit tests requested by the gemini-code-assist bot. The bot has already reviewed the latest changes and marked them as "looking good." It has been pending for a while, so could you please take a look or approve the workflows so we can get the CI checks running? Thanks! |
|
@gundermanc Could you please review this? It fixes the issue where the compression flag wasn't latching properly, which prevents unnecessary retry attempts. The bot has already verified the logic is sound. |
2 participants
The
hasFailedCompressionAttemptflag is intended to prevent the client from wastefully retrying automatic (non-forced) compression after it has already failed once with an inflated token count.The previous logic (
this.hasFailedCompressionAttempt = !force && true;) incorrectly reset this flag tofalseif a subsequent forced compression attempt also failed.This commit modifies the condition to only set the flag to
trueon a non-forced failure (&& !force). This ensures the flag latches correctly for the remainder of the session as intended, preventing inefficient retries and token usage.Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist