ci: include manifest build tasks into the main flow, attach pkgjsons to upload-artifact #1322
+30
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to upload-artifact
There was a problem hiding this comment.
Pull Request Overview
This PR integrates manifest build tasks into the main build flow and updates CI workflows to include generated package manifests as artifacts. The changes streamline the build process by consolidating manifest generation tasks and ensuring all necessary files are available for publishing workflows.
- Integrated manifest build tasks (JSR, lite, and main package.json generation) into the main build flow
- Updated CI workflows to include generated package manifests in upload artifacts
- Modified test files to use the new manifest file locations and simplified workflow steps
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added build:manifest task to main build flow and updated script references |
| scripts/build-pkgjson-main.mjs | Changed output filename to package-main.json for clarity |
| scripts/build-pkgjson-lite.mjs | Updated console message for consistency |
| scripts/build-jsr.mjs | Added console log for completion feedback |
| test/it/build-npm.test.js | Updated tests to use new manifest file locations |
| .github/workflows/test.yml | Added generated manifest files to upload artifacts |
| .github/workflows/publish.yml | Removed redundant build steps and updated file handling |
| .github/workflows/jsr-publish.yml | Removed redundant JSR build step |
| .github/workflows/dev-publish.yml | Removed redundant build steps and reordered publishing tasks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues #1320 #1321