refactor: optimize shell setters #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Aug 10, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors shell configuration functions to reduce code duplication by introducing a shared setShell helper function. The refactoring consolidates the logic for setting shell properties and reduces the overall bundle size.
Key changes:
- Replaced three separate shell configuration functions with a shared
setShellhelper - Converted function declarations to arrow function expressions
- Reduced bundle size limits reflecting the code optimization
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core.ts | Refactored shell setter functions to use shared setShell helper |
| build/core.cjs | Generated build output reflecting the TypeScript changes |
| .size-limit.json | Updated size limits to reflect reduced bundle size |
antongolub
force-pushed
the
refactor-shell-set
branch
from
75d8cb5 to
b9e2934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.