refactor: simplify ProcessPromise[asyncIterator] inners
#1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Aug 6, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ProcessPromise[asyncIterator] implementation to simplify the logic for handling different stdout stream types. The main change replaces a conditional check for async iterator support with a simpler fallback to an empty array.
- Simplifies stdout iteration logic in the async iterator implementation
- Updates test to use
sleep()helper function instead of manual Promise construction - Adds comprehensive test coverage for edge cases involving ignored and non-iterable stdio configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core.ts | Simplifies stdout iteration logic by replacing conditional async iterator check with empty array fallback |
| build/core.cjs | Generated build artifact reflecting the core.ts changes |
| test/core.test.js | Refactors existing test and adds new test cases for stdio edge cases |
| .size-limit.json | Updates bundle size limits to reflect the code simplification |
| for await (const chunk of this.stdout[Symbol.asyncIterator] | ||
| ? this.stdout | ||
| : VoidStream.from(this.stdout)) { | ||
| for await (const chunk of this.stdout || []) { |
There was a problem hiding this comment.
The fallback to an empty array [] may not handle all cases correctly. If this.stdout is a non-iterable object (like a file descriptor), this will silently skip iteration instead of properly handling the stream. The original code with VoidStream.from() was likely designed to handle such cases.
Suggested change
| for await (const chunk of this.stdout || []) { | |
| for await (const chunk of VoidStream.from(this.stdout)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.