chore: minor code imprs #1289
Merged
chore: minor code imprs #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 28, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
A minor code cleanup pull request focused on improving code style and formatting consistency across source and build files.
- Simplified arrow function formatting by removing unnecessary braces and line breaks
- Refactored error handling logic to use more concise conditional expressions
- Updated size limit configuration to reflect actual bundle size
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/util.ts | Simplified while loop formatting to single line |
| src/core.ts | Refactored error message getter with inline parameter assignment |
| build/util.cjs | Applied same formatting changes as source file |
| build/core.cjs | Applied same error handling refactor as source file |
| .size-limit.json | Updated bundle size limit to match actual size |
Comments suppressed due to low confidence (1)
build/core.cjs:892
- The variable name 'error2' is unclear and suggests a naming conflict. Consider using a more descriptive name like 'errorInstance' or 'resolvedError'.
(error2 = dto.error || message && new Error(message)) => error2 ? _ProcessOutput.getErrorMessage(error2, dto.from) : _ProcessOutput.getExitMessage(
antongolub
force-pushed
the
minor-code-imrps
branch
from
c538f92 to
6afac8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.