fix: handle nothrow on ProcessPromise init stage
#1288
Merged
+205
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error handling in the ProcessPromise initialization stage by properly supporting the nothrow option when errors occur during command building and validation.
- Refactors ProcessPromise initialization to defer command building and validation until construction
- Adds proper error handling with
nothrowsupport during the init stage - Removes global state management in favor of direct snapshot attachment
Reviewed Changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core.ts | Major refactor of ProcessPromise initialization, error handling, and command building logic |
| src/util.ts | Adds utility function to convert iterators to arrays |
| test/core.test.js | Adds test case for nothrow behavior with malformed commands |
| src/vendor-core.ts | Removes unused TSpawnResult type export |
| test-d/core.test-d.ts | Updates ProcessOutput constructor test expectation |
| package.json | Updates @types/node dependency version |
| build/ files | Generated build artifacts reflecting source changes |
| .size-limit.json | Updates size limits to accommodate code changes |
Comments suppressed due to low confidence (1)
src/core.ts:386
- The parameter name 'legacy' is unclear in this context. Consider renaming to something more descriptive like 'fromInitStage' or 'throwOnError' to better convey its purpose.
if (legacy) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.