feat: introduce Fail class
#1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Fail class that consolidates error handling functionality across the zx library. The class serves as a centralized error object that extends the native Error class and includes static methods for formatting error messages, exit codes, and caller locations.
- Replaces scattered error utility functions with a unified
Failclass - Migrates existing error formatting functions to static methods on the
Failclass - Updates all error instantiations throughout the codebase to use
Failinstead ofError
Reviewed Changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/error.ts | Refactors error utility functions into a new Fail class with static methods |
| src/core.ts | Updates to use Fail class for error handling and exports the new class |
| src/goods.ts | Replaces Error with Fail for error instantiation |
| src/deps.ts | Updates error throwing to use Fail class |
| src/cli.ts | Integrates Fail class and uses its DOCS_URL constant |
| test/error.test.ts | Updates test imports to use Fail class static methods |
| test/core.test.js | Adds test coverage for Fail class functionality |
| test/export.test.js | Adds export validation tests for Fail class and its properties |
| build/*.js | Generated build files reflecting the new Fail class integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.