refactor: rearrange core internals #1282
Conversation
antongolub
commented
Jul 23, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the core internals by reorganizing imports, reordering variable declarations, and making minor optimizations to the code structure without changing core functionality.
- Reorganizes import statements in alphabetical order and groups related imports
- Restructures internal variable declarations and moves functions to improve code organization
- Makes minor code simplifications in conditional expressions and variable extraction
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/core.ts | Reorganizes imports, reorders internal storage declarations, and simplifies conditional logic |
| build/core.cjs | Reflects the same reorganization changes from the TypeScript source in the compiled output |
| .size-limit.json | Updates size limits to reflect minor reductions from the refactoring |
| const self = this | ||
| const $ = self._snapshot | ||
| const id = self.id | ||
| const cwd = $.cwd ?? $[CWD] |
There was a problem hiding this comment.
[nitpick] Extracting cwd into a variable is unnecessary since it's only used once on line 303. This adds an extra variable assignment without providing any performance or readability benefit.
| return storage.run({ ...getStore() }, callback) | ||
| } | ||
|
|
||
| // The zx |
There was a problem hiding this comment.
The comment '// The zx' is incomplete and unclear. It should be expanded to properly describe what the following code section does, such as '// The zx shell interface and proxy implementation'.
| // The zx | |
| // The zx shell interface and proxy implementation. | |
| // This proxy handles template strings, manages snapshots of the shell state, | |
| // and interacts with a ProcessPromise to execute shell commands. |
1 participant
