refactor: align internal props names #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 20, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors internal property names within the ProcessPromise class to improve consistency. The main change renames the private _command property to _cmd throughout the codebase.
- Renames
_commandto_cmdacross TypeScript source, compiled JavaScript, and test files - Removes an unused
acproperty from a context object - Updates size limits to reflect the reduced bundle size from shorter property names
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core.ts | Updates private property name from _command to _cmd and removes unused ac property |
| build/core.cjs | Reflects the same property renaming changes in the compiled JavaScript output |
| test/core.test.js | Updates test code to use the new _cmd property name |
| .size-limit.json | Adjusts bundle size limits to reflect the smaller footprint from shorter property names |
Comments suppressed due to low confidence (1)
src/core.ts:301
- The removal of the 'ac' property from the context object should be verified to ensure it's not used elsewhere in the codebase. If this property was part of an interface or expected by other code, removing it could cause runtime errors.
signal: self.signal,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.