refactor: align AbortController and EventEmitter init approach
#1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 19, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the initialization approach for AbortController and EventEmitter to ensure consistency in the ProcessPromise class. The refactor moves AbortController initialization from the snapshot creation to the class constructor, aligning it with the existing EventEmitter pattern.
- Moves
AbortControllerinstantiation from snapshot to class constructor for consistent initialization - Adds a new
acgetter to provide access to the abort controller with fallback logic - Updates all references to use the new
acproperty instead of accessing it from the snapshot
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core.ts | Main refactor: adds _ac field, removes AC from snapshot, adds ac getter, updates references |
| build/core.cjs | Compiled output reflecting the TypeScript changes |
| package.json | Dependency updates for @types/node and esbuild |
| .size-limit.json | Updated size limits reflecting the code changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.