refactor: introduce internal ProcessPromise.isSync()
#1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 19, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an internal isSync() method to the ProcessPromise class to improve code maintainability by encapsulating synchronous execution checks. The refactoring replaces direct access to the SYNC symbol with a centralized method and updates related logic for consistency.
- Adds a private
isSync()method to centralize synchronous execution detection - Updates all references to use the new method instead of direct
snapshot[SYNC]access - Modifies the
isHalted()logic to consider synchronous processes as non-halted
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core.ts | Main refactoring with new isSync() method and updated logic |
| build/core.cjs | Compiled JavaScript reflecting the TypeScript changes |
| test/util.test.js | Adds test case for parseDuration(0) |
| docs/process-promise.md | Updates timeout documentation with clarifications |
| .size-limit.json | Updates bundle size limits reflecting code changes |
| if (this.isSettled()) throw new Error('Too late to abort the process.') | ||
| if (this.signal !== this._snapshot.ac?.signal) | ||
| const { ac } = this._snapshot | ||
| if (this.signal !== ac!.signal) |
There was a problem hiding this comment.
Using non-null assertion operator (!) without proper null checking. The original code used optional chaining. Consider adding a null check: if (!ac || this.signal !== ac.signal) to handle cases where ac might be undefined.
Suggested change
| if (this.signal !== ac!.signal) | |
| if (!ac || this.signal !== ac.signal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.