test: add basic ps API test
#1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antongolub
force-pushed
the
ps-test
branch
2 times, most recently
from
2647947 to
1c8c9dc
Compare
antonmedv
approved these changes
Jul 1, 2025
antongolub
force-pushed
the
ps-test
branch
3 times, most recently
from
115de0b to
538424b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic smoke tests for the ps lookup and abort-controller behavior, bumps several dev dependency versions, refines grid‐parsing logic in the vendor bundle, and updates size‐limit thresholds.
- Add
ps.lookupand abort controller tests in both Win32 and Node smoke suites - Bump dev dependencies (
@types/node,esbuild,jsr,lefthook, etc.) - Enhance
parseLinesandparseWinGridlogic inbuild/vendor-core.cjs - Update
.size-limit.jsonthresholds to reflect bundle changes
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/win32.test.js | Add ps API and abort-controller tests; import cleanup |
| test/smoke/node.test.mjs | Add inline ps API and abort-controller blocks |
| package.json | Bump various dev dependency versions |
| build/vendor-core.cjs | Introduce EMPTY constant; filter out blank lines; overhaul WinGrid parsing |
| .size-limit.json | Increase limits to match updated bundle sizes |
Comments suppressed due to low confidence (1)
build/vendor-core.cjs:817
- [nitpick] Filtering out empty lines with
.filter(Boolean)changes behavior from the previous implementation; adding a comment explaining why blank lines are dropped would help future maintainers.
var parseLines = (input, sep) => input.split(EOL).filter(Boolean).map((l) => parseLine(l, sep));
test/smoke/win32.test.js
Outdated
|
|
||
| import assert from 'node:assert' | ||
| import { test, describe } from 'node:test' | ||
| import cp from 'child_process' |
There was a problem hiding this comment.
The cp import from 'child_process' is not used in this test file and can be removed to reduce noise.
Suggested change
| import cp from 'child_process' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #1263