[cargo-zerocopy] Pass failure return codes through #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
requested changes
Feb 26, 2024
Member
joshlf
left a comment
joshlf
left a comment
There was a problem hiding this comment.
Thanks for such a quick turnaround! Two small requests, but otherwise looks good.
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
5a2074a to
02fbca4
Compare
This was referenced Feb 26, 2024
joshlf
added a commit
that referenced
this pull request
Feb 26, 2024
This shouldn't have made it onto `main`, but was able to as a result of the bug described in #947. While we're here, add an `assert!` that prevents us from running UI tests when the `derive` feature is disabled. The `derive` feature is required in order for UI tests to produce sensible output, and running without it enabled is a common source of mis-steps when developing that ends up slowing us down. This will need to merge before #948 can merge.
Merged
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
02fbca4 to
60e3b66
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
This shouldn't have made it onto `main`, but was able to as a result of the bug described in #947. While we're here, add an `assert!` that prevents us from running UI tests when the `derive` feature is disabled. The `derive` feature is required in order for UI tests to produce sensible output, and running without it enabled is a common source of mis-steps when developing that ends up slowing us down. This will need to merge before #948 can merge.
Merged
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
60e3b66 to
f3e92bb
Compare
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
f3e92bb to
2dd3720
Compare
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
2dd3720 to
d66826b
Compare
Merged
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
d66826b to
57d0696
Compare
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
2 times, most recently
from
d3c7597 to
ca7fe60
Compare
joshlf
force-pushed
the
fix_cargo_exit_codes
branch
from
ca7fe60 to
2507b2e
Compare
joshlf
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #947