Support testing TryFromBytes for !NoCell types #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
maybe-uninit-no-cell-try-from-bytes
branch
from
eb3782d to
8e63e62
Compare
jswrenn
previously approved these changes
Feb 22, 2024
Collaborator
jswrenn
left a comment
jswrenn
left a comment
There was a problem hiding this comment.
Well, I can't say I approve of this in the moral sense, but I will approve it. 😅
joshlf
force-pushed
the
maybe-uninit-no-cell-try-from-bytes
branch
6 times, most recently
from
cac564a to
1ec42ba
Compare
Previously, our test harness for `TryFromBytes` types assumed that those types also implemented `NoCell`. This commit introduces machinery that allows us to conditionally execute certain steps of our tests depending on whether or not the type under test implements `NoCell`. This commit also lifts the `T: NoCell` bound in `TryFromBytes for MaybeUninit<T>` in order to test this machinery. Makes progress on #5 Co-authored-by: Jack Wrenn <[email protected]>
joshlf
force-pushed
the
maybe-uninit-no-cell-try-from-bytes
branch
from
1ec42ba to
e872051
Compare
jswrenn
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our test harness for
TryFromBytestypes assumed that those types also implementedNoCell. This commit introduces machinery that allows us to conditionally execute certain steps of our tests depending on whether or not the type under test implementsNoCell.This commit also lifts the
T: NoCellbound inTryFromBytes for MaybeUninit<T>in order to test this machinery.