• zerocopy-derive/src/derive/from_bytes.rs
  • Modified error returns to use ctx.error_or_fail_silently for #[repr(C)] or #[repr(Int)] checks.
  • Applied ctx.error_or_fail_silently to errors related to enum variant discriminants and variant count mismatches.
• zerocopy-derive/src/derive/into_bytes.rs
  • Updated error handling to use ctx.error_or_fail_silently for #[repr(...)] attribute validation.
  • Applied ctx.error_or_fail_silently to errors for types with type parameters and incorrect #[repr(...)] attributes.
• zerocopy-derive/src/derive/try_from_bytes.rs
  • Adjusted derive_is_bit_valid call to return an empty TokenStream on error if fail_silently is active.
  • Added !ctx.fail_silently condition to try_gen_trivial_is_bit_valid to prevent trivial FromBytes implementation when failing silently.
• zerocopy-derive/src/derive/unaligned.rs
  • Converted error returns to use ctx.error_or_fail_silently for #[repr(...)] attribute checks for structs, enums, and unions.
• zerocopy-derive/src/util.rs
  • Added fail_silently: bool field to the Ctx struct to track the new attribute's presence.
  • Implemented parsing logic for the derive_fail_silently attribute within Ctx::try_from_derive_input.
  • Updated Ctx::with_input to correctly propagate the fail_silently flag.
  • Introduced Ctx::error_or_fail_silently to encapsulate the conditional error return or silent failure.
  • Added #[allow(trivial_bounds)] to the generated impl block when fail_silently is true.
• zerocopy-derive/tests/fail_silently.rs
  • Added a new test file to validate the behavior of #[zerocopy(derive_fail_silently)].
  • Includes tests for error suppression for IntoBytes and Unaligned on a repr(Rust) struct.
  • Verifies FromBytes is still implemented for valid cases even with fail_silently.
  • Tests the trivial_bounds suppression with a generic struct.

• The pull request introduces a new #[zerocopy(derive_fail_silently)] attribute, addressing issue Support silent failure in derives #1769.
• Core changes involve modifying the Ctx struct to include a fail_silently flag and adding a new error_or_fail_silently utility function.
• Existing derive logic across from_bytes.rs, into_bytes.rs, try_from_bytes.rs, and unaligned.rs has been updated to utilize this new error handling mechanism.
• A new test file, fail_silently.rs, has been added to thoroughly validate the functionality of the new attribute, including its impact on trait implementation and trivial_bounds warnings.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.