[derive] Store output test goldens in separate files#2904
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the testing infrastructure for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the output tests for zerocopy-derive by moving the expected output into separate .rs files. This change significantly improves the maintainability and reviewability of the test goldens, making it easier to track and update expected macro expansions. The update to ci/check_fmt.sh to exclude these generated files from formatting checks is also appropriate and prevents unnecessary linting failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 20 20
Lines 5877 5877
=======================================
Hits 5401 5401
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G66ceda30436ea649540ec804dc64926483988008
branch
from
2f7def7 to
539552e
Compare
joshlf
force-pushed
the
G66ceda30436ea649540ec804dc64926483988008
branch
from
539552e to
abc3d6f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
joshlf
force-pushed
the
G66ceda30436ea649540ec804dc64926483988008
branch
from
abc3d6f to
85454ad
Compare
Update zerocopy-derive output tests so that each test's expected output lives in its own `expected.rs` file. This should make changes to test output easier to update and review. Makes progress on #2903 gherrit-pr-id: G66ceda30436ea649540ec804dc64926483988008
joshlf
force-pushed
the
G66ceda30436ea649540ec804dc64926483988008
branch
from
85454ad to
5589919
Compare
3 participants
Update zerocopy-derive output tests so that each test's expected output
lives in its own
expected.rsfile. This should make changes to testoutput easier to update and review.
Makes progress on #2903
Latest Update: v6 — Compare vs v5
📚 Full Patch History
Links show the diff between the row version and the column version.