Skip to content

Comments

Add tests targeted at un-covered lines of code#2833

Merged
joshlf merged 1 commit intomainfrom
coverage
Dec 2, 2025
Merged

Add tests targeted at un-covered lines of code#2833
joshlf merged 1 commit intomainfrom
coverage

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Nov 26, 2025

No description provided.

@joshlf joshlf changed the title Test coverage improvements Add tests targetted at un-covered lines of code Nov 26, 2025
@joshlf joshlf changed the title Add tests targetted at un-covered lines of code Add tests targeted at un-covered lines of code Nov 26, 2025
@joshlf joshlf force-pushed the coverage branch 2 times, most recently from 9c092b7 to 66f9c81 Compare November 26, 2025 14:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 98.54651% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.33%. Comparing base (5226dee) to head (5ae09a0).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/error.rs 96.26% 4 Missing ⚠️
src/layout.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2833      +/-   ##
==========================================
+ Coverage   88.14%   92.33%   +4.19%     
==========================================
  Files          20       20              
  Lines        5450     5794     +344     
==========================================
+ Hits         4804     5350     +546     
+ Misses        646      444     -202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the coverage branch 5 times, most recently from 9b10260 to 925ea73 Compare December 1, 2025 22:25
@joshlf joshlf marked this pull request as ready for review December 1, 2025 22:26
@joshlf joshlf enabled auto-merge December 1, 2025 22:26
@joshlf joshlf requested a review from jswrenn December 1, 2025 22:26
Copy link
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the improvement!

@joshlf joshlf added this pull request to the merge queue Dec 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 1, 2025
@joshlf joshlf enabled auto-merge December 2, 2025 00:04
@joshlf joshlf added this pull request to the merge queue Dec 2, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2025
gherrit-pr-id: I750fa15db914ce682c15e5030dec28f445a4bd5b
gherrit-pr-id: I750fa15db914ce682c15e5030dec28f445a4bd5b
@joshlf joshlf removed this pull request from the merge queue due to a manual request Dec 2, 2025
@joshlf joshlf enabled auto-merge December 2, 2025 00:16
@joshlf joshlf added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 8f910fc Dec 2, 2025
102 checks passed
@joshlf joshlf deleted the coverage branch December 2, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants