Merged
Conversation
This was referenced Mar 6, 2025
joshlf
force-pushed
the
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
branch
from
6804ba4 to
e9e0c22
Compare
joshlf
force-pushed
the
I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
branch
from
39d58a9 to
4acef46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## I569b74086a5f98cda71b4a4131f9ce4f89dcc623 #2423 +/- ##
==========================================================================
Coverage 87.53% 87.53%
==========================================================================
Files 18 18
Lines 6408 6408
==========================================================================
Hits 5609 5609
Misses 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
branch
from
e9e0c22 to
5d6aea8
Compare
joshlf
force-pushed
the
I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
branch
from
4acef46 to
54a93ee
Compare
joshlf
force-pushed
the
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
branch
from
5d6aea8 to
8b454f6
Compare
joshlf
force-pushed
the
I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
branch
from
54a93ee to
4f87922
Compare
joshlf
force-pushed
the
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
branch
from
8b454f6 to
018c8d4
Compare
joshlf
force-pushed
the
I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
branch
from
4f87922 to
20c8d98
Compare
This was referenced Mar 7, 2025
joshlf
force-pushed
the
I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
branch
from
20c8d98 to
4d09d7c
Compare
joshlf
force-pushed
the
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
branch
from
018c8d4 to
6d4d811
Compare
Closes #1253 gherrit-pr-id: I569b74086a5f98cda71b4a4131f9ce4f89dcc623
In #2408, we simplified the safety precondition of `unsafe_impl!`, but did not remove safety proofs at call sites made redundant by that simplification. This commit removes those now-obsolete proofs. gherrit-pr-id: I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
joshlf
force-pushed
the
I70d5aa5ace6bd2e39e679eac7f00a66d4b843d57
branch
from
4d09d7c to
f2ec335
Compare
joshlf
force-pushed
the
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
branch
from
6d4d811 to
1da86a4
Compare
jswrenn
approved these changes
Mar 8, 2025
Base automatically changed from
I569b74086a5f98cda71b4a4131f9ce4f89dcc623
to
main
March 8, 2025 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2408, we simplified the safety precondition of
unsafe_impl!, butdid not remove safety proofs at call sites made redundant by that
simplification. This commit removes those now-obsolete proofs.
This PR is on branch cell-traits.