Conversation
Member
Author
|
Backporting #2351 |
jswrenn
approved these changes
Feb 25, 2025
Previously, `Ptr<'a, T>` and `PtrInner<'a, T>` documented themselves to be covariant in both `'a` and `T`. This was true for `PtrInner`, but not for `Ptr`, which used GATs, which are invariant. This is also not the desired variance: for `Exclusive` aliasing, the desired variance matches that of `&mut` references - namely, covariant in `'a` but invariant in `T`. This commit fixes this by making `Ptr<'a, T>` and `PtrInner<'a, T>` unconditionally covariant in `'a` and invariant in `T`. gherrit-pr-id: I29f8429d9d7b14026313f030f8dc1e895a98ad56
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2393 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 17 17
Lines 6200 6200
=======================================
Hits 5445 5445
Misses 755 755 ☔ View full report in Codecov by Sentry. |
13 tasks
auto-merge was automatically disabled
February 25, 2025 18:59
Pull Request is not mergeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Ptr<'a, T>andPtrInner<'a, T>documented themselves to be covariant in both'aandT. This was true forPtrInner, but not forPtr, which used GATs, which are invariant. This is also not the desired variance: forExclusivealiasing, the desired variance matches that of&mutreferences - namely, covariant in'abut invariant inT.This commit fixes this by making
Ptr<'a, T>andPtrInner<'a, T>unconditionally covariant in'aand invariant inT.gherrit-pr-id: I29f8429d9d7b14026313f030f8dc1e895a98ad56