Fix soundness of FromBytes::read_from_io#2320
Merged
joshlf merged 1 commit intogoogle:mainfrom Feb 19, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
- Coverage 89.32% 89.31% -0.02%
==========================================
Files 16 16
Lines 6025 6045 +20
==========================================
+ Hits 5382 5399 +17
- Misses 643 646 +3 ☔ View full report in Codecov by Sentry. |
kupiakos
added a commit
to kupiakos/zerocopy
that referenced
this pull request
Feb 7, 2025
See google#2319. Backport of google#2320.
kupiakos
added a commit
to kupiakos/zerocopy
that referenced
this pull request
Feb 7, 2025
See google#2319. Backport of google#2320.
kupiakos
force-pushed
the
fromzeros-soundness-0.9
branch
2 times, most recently
from
867129d to
a6bb505
Compare
kupiakos
added a commit
to kupiakos/zerocopy
that referenced
this pull request
Feb 8, 2025
See google#2319. Backport of google#2320. Includes a Miri test confirming the previous unsoundness.
kupiakos
added a commit
to kupiakos/zerocopy
that referenced
this pull request
Feb 8, 2025
See google#2319. Backport of google#2320. Includes a Miri test confirming the previous unsoundness.
kupiakos
force-pushed
the
fromzeros-soundness-0.9
branch
from
a6bb505 to
9ab80be
Compare
Contributor
Author
|
I've confirmed that the new test fails Miri when run without the change in |
jswrenn
approved these changes
Feb 17, 2025
Collaborator
jswrenn
left a comment
jswrenn
left a comment
There was a problem hiding this comment.
This looks reasonable to me. We really ought to update FromZeros::new_zeroed to match the disclaimers of MaybeUninit::zeroed, but that's a distinct issue from the one you're fixing and can be handled in a follow-up PR.
kupiakos
force-pushed
the
fromzeros-soundness-0.9
branch
from
9ab80be to
0a9c7b6
Compare
joshlf
requested changes
Feb 17, 2025
Member
joshlf
left a comment
joshlf
left a comment
There was a problem hiding this comment.
Awesome, thank you for catching this! Two small comment nits, but otherwise looks good.
joshlf
force-pushed
the
fromzeros-soundness-0.9
branch
from
0a9c7b6 to
ce321e2
Compare
joshlf
approved these changes
Feb 19, 2025
See google#2319. Includes a Miri test confirming the previous unsoundness. gherrit-pr-id: Iede94c196c710c74d970c93935f1539e07446e50
joshlf
force-pushed
the
fromzeros-soundness-0.9
branch
from
ce321e2 to
dad322d
Compare
google-pr-creation-bot
pushed a commit
to google-pr-creation-bot/zerocopy
that referenced
this pull request
Feb 19, 2025
See google#2319. Includes a Miri test confirming the previous unsoundness. gherrit-pr-id: Iede94c196c710c74d970c93935f1539e07446e50
Member
|
Backporting to 0.8 in #2358 |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
See #2319. Includes a Miri test confirming the previous unsoundness. gherrit-pr-id: Iede94c196c710c74d970c93935f1539e07446e50 Co-authored-by: Alyssa Haroldsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2319.