[pointer] Make invariants opaque, more ergonomic#1895
Merged
Conversation
joshlf
changed the title
auto-merge was automatically disabled
October 12, 2024 22:51
Merge commits are not allowed on this repository
Member
Author
|
@jswrenn I didn't update any methods which modify two of three invariants. Any galaxy brain ideas on how to make those ergonomic? The best I could come up with was yet another set of associated types e.g.: type RetainAliasing<A: Alignment, V: Validity> = ...;...but that's not forwards-compatible with adding new invariant types. |
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
7c245c5 to
062b71a
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
3ab2c00 to
cf218f6
Compare
jswrenn
reviewed
Oct 14, 2024
jswrenn
approved these changes
Oct 14, 2024
joshlf
force-pushed
the
ptr-opaque-invariants
branch
2 times, most recently
from
9eab1bd to
39d2339
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
cf218f6 to
77362c9
Compare
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
39d2339 to
da4069e
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
77362c9 to
25de780
Compare
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
da4069e to
2172f24
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
25de780 to
d96d763
Compare
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
2172f24 to
2a92f9f
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
d96d763 to
471f4a9
Compare
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
2a92f9f to
9e69c15
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
471f4a9 to
25ddf05
Compare
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
9e69c15 to
19875da
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
25ddf05 to
87a434a
Compare
joshlf
force-pushed
the
ptr-opaque-invariants
branch
from
19875da to
029d5d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
- Coverage 87.65% 87.64% -0.02%
==========================================
Files 17 17
Lines 5964 5956 -8
==========================================
- Hits 5228 5220 -8
Misses 736 736 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1876