Rename generic param to avoid name collision #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djkoloski
force-pushed
the
rename_is_bit_valid_param
branch
from
7455f16 to
bd5fd67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
- Coverage 88.36% 88.01% -0.35%
==========================================
Files 16 16
Lines 5810 5833 +23
==========================================
Hits 5134 5134
- Misses 676 699 +23 ☔ View full report in Codecov by Sentry. |
jswrenn
requested changes
Sep 20, 2024
Comment on lines
+271
to
+280
|
|
||
| #[derive(Clone, Copy, imp::TryFromBytes)] | ||
| struct A; | ||
|
|
||
| #[derive(imp::TryFromBytes)] | ||
| #[repr(C)] | ||
| enum B { | ||
| A(A), | ||
| A2 { a: A }, | ||
| } |
There was a problem hiding this comment.
Could you add a UI test for the case where a field type is named ___ZerocopyAliasing? We want to be sure this doesn't regress (i.e., start compiling successfully).
There was a problem hiding this comment.
So that we can unblock Fuchsia users who are depending on this, I'm going to merge this w/o extra tests, but I added the following to the release roadmap to track (note the last bullet, which links to this comment thread and to #1725):
This was referenced Sep 22, 2024
Also makes the signatures of is_bit_valid generated for structs, unions, and enums the same.
joshlf
force-pushed
the
rename_is_bit_valid_param
branch
from
bd5fd67 to
7af6a22
Compare
joshlf
approved these changes
Sep 23, 2024
jswrenn
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the signatures of is_bit_valid generated for structs, unions, and enums the same.