Parse the package manifest directly for toolchains#1564
Merged
djkoloski merged 1 commit intogoogle:mainfrom Jul 30, 2024
Merged
Parse the package manifest directly for toolchains#1564djkoloski merged 1 commit intogoogle:mainfrom
djkoloski merged 1 commit intogoogle:mainfrom
Conversation
djkoloski
force-pushed
the
pin_syn_with_matrix_toolchain
branch
from
ad2ff41 to
bc877de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 15 15
Lines 5563 5563
=======================================
Hits 4879 4879
Misses 684 684 ☔ View full report in Codecov by Sentry. |
djkoloski
force-pushed
the
pin_syn_with_matrix_toolchain
branch
4 times, most recently
from
97c5d2d to
a367053
Compare
djkoloski
changed the title
This prevents the lockfile for the workspace from being generated by a newer version of cargo, which may choose more up-to-date dependencies than our msrv toolchain can compile.
djkoloski
force-pushed
the
pin_syn_with_matrix_toolchain
branch
from
a367053 to
2c6f242
Compare
joshlf
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the lockfile for the workspace from being generated by a newer version of cargo, which may choose more up-to-date dependencies than our msrv toolchain can compile.