modules/zstd: add raw block decoder#1212
Closed
rw1nkler wants to merge 13 commits intogoogle:mainfrom
Closed
Conversation
lpawelcz
force-pushed
the
51343-raw-blocks
branch
from
24bf8f8 to
7feef18
Compare
lpawelcz
force-pushed
the
51343-raw-blocks
branch
4 times, most recently
from
1a12c5e to
8397aea
Compare
lpawelcz
force-pushed
the
51343-raw-blocks
branch
from
8397aea to
ac24f27
Compare
lpawelcz
force-pushed
the
51343-raw-blocks
branch
3 times, most recently
from
4f0cdd2 to
7088e8c
Compare
lpawelcz
force-pushed
the
51343-raw-blocks
branch
2 times, most recently
from
50b1c5c to
98cd055
Compare
lpawelcz
force-pushed
the
51343-raw-blocks
branch
from
98cd055 to
8cd0aa2
Compare
This commit adds a DSLX Buffer library that provides the Buffer struct, and helper functions that can be used to operate on it. The Buffer is meant to be a storage for data coming from the channel. It acts like a FIFO, allowing data of any length to be put in or popped out of it. Provided DSLX tests verify the correct behaviour of the library. Internal-tag: [#50221] Signed-off-by: Robert Winkler <[email protected]>
This commit adds a simple test that shows, how one can use the Buffer struct inside a Proc. Internal-tag: [#50221] Signed-off-by: Robert Winkler <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
This commit adds the library with functions for parsing a magic number and tests that verify its correctness. Internal-tag: [#50221] Signed-off-by: Robert Winkler <[email protected]>
This commit adds the library with functions for parsing a frame header. The provided tests verify the correcness of the library. Internal-tag: [#49967] Co-authored-by: Roman Dobrodii <[email protected]> Co-authored-by: Pawel Czarnecki <[email protected]> Signed-off-by: Robert Winkler <[email protected]> Signed-off-by: Pawel Czarnecki <[email protected]>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <[email protected]>
Required for expected_status inference in C++ tests for ZSTD decoder components Internal-tag: [#53465] Signed-off-by: Pawel Czarnecki <[email protected]>
Internal-tag: [#50967] Signed-off-by: Robert Winkler <[email protected]>
This commit adds a binary that calls decoding to generate data and loads it into a vector of bytes. Internal-tag: [#50967] Signed-off-by: Robert Winkler <[email protected]>
Internal-tag: [#50967] Co-authored-by: Pawel Czarnecki <[email protected]> Signed-off-by: Robert Winkler <[email protected]> Signed-off-by: Pawel Czarnecki <[email protected]>
Internal-tag: [#51343] Signed-off-by: Robert Winkler <[email protected]>
Internal-tag: [#51343] Signed-off-by: Robert Winkler <[email protected]>
Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <[email protected]>
lpawelcz
force-pushed
the
51343-raw-blocks
branch
from
8cd0aa2 to
09267ae
Compare
lpawelcz
pushed a commit
to antmicro/xls
that referenced
this pull request
Feb 21, 2024
google#1212 modules/zstd: Add common zstd definitions Internal-tag: [#51343] Signed-off-by: Robert Winkler <[email protected]> modules/zstd: Add raw block decoder Internal-tag: [#51343] Signed-off-by: Robert Winkler <[email protected]> modules/zstd/raw_block_decoder: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <[email protected]>
lpawelcz
pushed a commit
to antmicro/xls
that referenced
this pull request
Mar 7, 2024
google#1212 modules/zstd: Add common zstd definitions Internal-tag: [#51343] Signed-off-by: Robert Winkler <[email protected]> modules/zstd: Add raw block decoder Internal-tag: [#51343] Signed-off-by: Robert Winkler <[email protected]> modules/zstd/raw_block_decoder: Add benchmarking rules Internal-tag: [#53329] Signed-off-by: Pawel Czarnecki <[email protected]>
cdleary
added
the
app
Member
|
should we close this and focus on reviewing #1315 ? |
Contributor
Author
|
Closing, as the review will happen in #1315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds RawBlockDecoder Proc which is responsible for decoding ZSTD Raw Blocks. More information about Raw Block's format can be found in Section 3.1.1.2.2 of RFC8788. The Proc acts as a simple passthrough for the incoming data. It will be a part of the larger decoding pipeline.
NOTE: this is based on #1168 , please ignore commits from that branch when reviewing.
CC @proppy