modules/zstd: build libzstd#1166
Conversation
Do we need to those? It sounds like we would motsly need to drive (software)-zstd from C++ tests to compare data with DSLX/IR simulation (and not from the shell or bazel rules). |
|
They were added for our convenience during development but we can remove those two targets from the build file. Later, we will extend the build rules to expose internal ZSTD headers because we need them for more advanced tests. |
rw1nkler
force-pushed
the
49966-zstd-cleaned
branch
from
a4d9ebd to
c951741
Compare
proppy
left a comment
proppy
left a comment
There was a problem hiding this comment.
can you squash the commits, and rename the PR (without the part 1)
proppy
changed the title
|
also if you rebase, that should get rid of the macosx continuous integration failure which is already fixed at HEAD (and it only runs nightly now) |
rw1nkler
force-pushed
the
49966-zstd-cleaned
branch
from
c951741 to
c5d630a
Compare
| ], | ||
| ) | ||
|
|
||
| http_archive( |
There was a problem hiding this comment.
Could you add a comment saying the date this was fresh?
There was a problem hiding this comment.
Added comment with release info and dependency update date
| ], | ||
| strip_include_prefix = "lib", | ||
| linkopts = [ | ||
| "-pthread", |
There was a problem hiding this comment.
Is this necessary? I'd have thought not
There was a problem hiding this comment.
It looks like disabling multithread builds does not affect our tests which use zstd library. I've updated the build rule to build library without multithread support.
lpawelcz
force-pushed
the
49966-zstd-cleaned
branch
2 times, most recently
from
f364507 to
75a6a22
Compare
This commit enables building zstd library in version 1.4.7 in the XLS repository. The sources of the library come from the official release of zstd on Meta's GitHub. Internal-tag: #[49966] Signed-off-by: Robert Winkler <[email protected]>
Internal-tag: [#49966] Signed-off-by: Pawel Czarnecki <[email protected]>
Disable building llvm with zstd to avoid conflicts with newly-added zstd library. It seems that llvm_zstd is not necessary for correct llvm operation. Internal-tag: #[49966] Signed-off-by: Robert Winkler <[email protected]>
5 participants
This PR adds zstd library to the XLS framework. It exposes the following targets:
Additionally, we remove zstd from llvm build to avoid linking conflicts with newly-added zstd library. It seems that llvm_zstd is not necessary for correct llvm operation.