[xarray-beam] avoid compatibility checks inside _DiscoverTemplate #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_375839385
branch
3 times, most recently
from
f584327 to
9cd5380
Compare
The default behavior for compat in xarray.combine_nested() is
"no_conflicts", which actually calls the fillna() method on variables
in a loop:
out = variables[0]
for var in variables[1:]:
out = out.fillna(var)
https://github.com/pydata/xarray/blob/55e5b5aaa6d9c27adcf9a7cb1f6ac3bf71c10dea/xarray/core/merge.py#L147-L149
This has quadratic behavior if the variables are stored in dask arrays
(the dask graph gets one element larger after each loop iteration).
PiperOrigin-RevId: 375846544
copybara-service
bot
force-pushed
the
test_375839385
branch
from
9cd5380 to
2bd1139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xarray-beam] avoid compatibility checks inside _DiscoverTemplate
The default behavior for compat in xarray.combine_nested() is
"no_conflicts", which actually calls the fillna() method on variables
in a loop:
out = variables[0]
for var in variables[1:]:
out = out.fillna(var)
https://github.com/pydata/xarray/blob/55e5b5aaa6d9c27adcf9a7cb1f6ac3bf71c10dea/xarray/core/merge.py#L147-L149
This has quadratic behavior if the variables are stored in dask arrays
(the dask graph gets one element larger after each loop iteration).