Repository navigation
Refactor matchState initialization to use literal - #349
Conversation
The updated type of `matchState` can lead to some type errors with existing tests.
Fixes a regression in async matchers that could lead to type errors in tests.
Package publishingIf you have publishing permissions, you can use the links below to publish the changes after merging this PR.
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
Weird, but okay. 😄 I trust you...
For context, Maybe |
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/7e8caaf..51cf766): 51cf7664 Thu Sep 10 17:49:25 2026 -0700 Kevin Moore test(crypto): add C2SP/Wycheproof test vectors for HMAC (dart-lang/core#993) native (https://github.com/dart-lang/native/compare/84d7eda..f2b4942): f2b4942cc Fri Sep 11 07:59:55 2026 +0530 Sivapriya [jnigen] Relax binding verification test (dart-lang/native#3627) protobuf (https://github.com/dart-lang/protobuf/compare/cde8e28..a73edc9): a73edc9 Fri Sep 11 12:54:45 2026 +0100 Martin Kustermann Remove legacy interop use (conditional import on dart.library.html) (google/protobuf.dart#1102) webdriver (https://github.com/google/webdriver.dart/compare/9b2e87d..8e5c611): 8e5c611 Fri Sep 11 01:32:05 2026 -0400 Nate Biggs Refactor matchState initialization to use untyped literal (google/webdriver.dart#349) TAG=agy CONV=688fe3c8-47b5-4273-96f1-b13470d355b6 [email protected] Change-Id: I3c2cb3870ccc229206da7d27a3b8ece7a1492842 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/548981 Reviewed-by: Brian Quinlan <[email protected]> Commit-Queue: Nate Bosch <[email protected]>
The updated type of
matchStatecan lead to some type errors with existing tests.