Skip to content

Fix branch table logic#776

Merged
ia0 merged 1 commit into
google:dev/fast-interpfrom
ia0:pop-cnt
Mar 7, 2025
Merged

Fix branch table logic#776
ia0 merged 1 commit into
google:dev/fast-interpfrom
ia0:pop-cnt

Conversation

@ia0

@ia0 ia0 commented Mar 7, 2025

Copy link
Copy Markdown
Member

The main changes are:

  • Do not create a branch table entry for unreachable code. This saves space and permits a uniform treatment of branches.
  • Use the correct stack length for the Loop branch target (we're taking the branch before being in the label, so the current stack needs to be added).
  • Take the Else source and target branches at the correct time (i.e. when the stack is the expected one such that the stack length is correctly computed).

@ia0
ia0 requested review from ia0-review and zhouwfang March 7, 2025 10:07
The main changes are:
- Do not create a branch table entry for unreachable code. This saves space and permits a uniform
  treatment of branches.
- Use the correct stack length for the Loop branch target (we're taking the branch before being in
  the label, so the current stack needs to be added).
- Take the Else source and target branches at the correct time (i.e. when the stack is the expected
  one such that the stack length is correctly computed).
@ia0
ia0 merged commit 9f89c67 into google:dev/fast-interp Mar 7, 2025
@ia0
ia0 deleted the pop-cnt branch March 7, 2025 10:22
@zhouwfang

Copy link
Copy Markdown
Contributor

#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants