Skip to content

Improve the performance of function accessors#723

Merged
ia0 merged 10 commits into
google:dev/fast-interpfrom
zhouwfang:apply-new-side-table
Jan 17, 2025
Merged

Improve the performance of function accessors#723
ia0 merged 10 commits into
google:dev/fast-interpfrom
zhouwfang:apply-new-side-table

Conversation

@zhouwfang

@zhouwfang zhouwfang commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

CoreMark result: 37.404152 (in 18.937s)

Slight performance improvement on Linux compared to the previous state.

#46

@zhouwfang
zhouwfang requested a review from ia0 as a code owner January 16, 2025 05:53
@zhouwfang zhouwfang mentioned this pull request Jan 16, 2025
Closed
zhouwfang
zhouwfang commented Jan 16, 2025
View reviewed changes
Comment thread crates/interpreter/src/side_table.rs Outdated
zhouwfang
zhouwfang commented Jan 16, 2025
View reviewed changes
Comment thread crates/interpreter/src/valid.rs Outdated
zhouwfang
zhouwfang commented Jan 16, 2025
View reviewed changes
Comment thread crates/interpreter/src/valid.rs Outdated
zhouwfang
zhouwfang commented Jan 16, 2025
View reviewed changes
Comment thread crates/interpreter/src/valid.rs
ia0
ia0 reviewed Jan 16, 2025
View reviewed changes

@ia0 ia0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks generally good, the only big problem is that code start should be store in the side table, not in each metadata.

Comment thread crates/interpreter/src/module.rs Outdated
Comment thread crates/interpreter/src/side_table.rs Outdated
Comment thread crates/interpreter/src/valid.rs Outdated
Comment thread crates/interpreter/src/valid.rs Outdated
@zhouwfang
zhouwfang requested a review from ia0 January 17, 2025 03:26
zhouwfang
zhouwfang commented Jan 17, 2025
View reviewed changes
Comment thread crates/interpreter/src/valid.rs
@zhouwfang

zhouwfang commented Jan 17, 2025

Copy link
Copy Markdown
Contributor Author

@ia0 Could you help me get the metrics after this PR on nordic? Thanks.

ia0
ia0 approved these changes Jan 17, 2025
View reviewed changes

@ia0 ia0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread crates/interpreter/src/valid.rs
@ia0
ia0 merged commit 8017774 into google:dev/fast-interp Jan 17, 2025
@zhouwfang

zhouwfang commented Jan 20, 2025

Copy link
Copy Markdown
Contributor Author

@ia0 Could you help me get the metrics after this PR on nordic? Thanks.

@ia0 When you get some time, could you take a look? I'm still working on making the nordic DK work with my laptop.

@ia0

ia0 commented Jan 20, 2025

Copy link
Copy Markdown
Member

Oops I missed that comment.

Before:

Peak RAM usage: 5668
CoreMark result: 0.15474127 (in 129.514s)

After:

Peak RAM usage: 5668
Peak RAM usage: 5684
CoreMark result: 0.15614265 (in 128.356s)

The peak RAM was 5668 during the whole test but only increased at the end. It's anyway rather minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ia0 ia0 ia0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhouwfang @ia0