Optimize side table masks#713
Merged
Merged
Conversation
ia0
approved these changes
Jan 3, 2025
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
That's most probably too strict on the counts. I think we should eventually end up with:
- 16 bits delta IP
- 16 bits delta STP
- 4 bits val count
- 12 bits pop count
This gives 48 bits aligned on 16 bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on experiments, these are the smallest masks to pass CI. In other words,
SideTableEntryonly requiresu35at this point. I'll add the fields fromfunc_type()andfunc()inmodule.rsto the side table in #711, andSideTableEntryasu64might not be sufficient.#46