Add prev_stack in Frame#707
Merged
Merged
Conversation
Improve the performance by removing last_frame_values_cnt()
ia0
reviewed
Dec 23, 2024
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
Thanks! LGTM modulo the Option<usize> which seems redundant.
ia0
approved these changes
Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It improves the performance by removing the costly
last_frame_values_cnt().On linux,
CoreMark result: 39.795715 (in 17.853s). cf. CoreMark result was about 37 in 19s in #705.#46