Skip to content

Fix val_cnt for if#706

Merged
ia0 merged 6 commits into
google:dev/fast-interpfrom
zhouwfang:fix-valcnt-for-if
Dec 23, 2024
Merged

Fix val_cnt for if#706
ia0 merged 6 commits into
google:dev/fast-interpfrom
zhouwfang:fix-valcnt-for-if

Conversation

@zhouwfang

Copy link
Copy Markdown
Contributor

#46

@zhouwfang
zhouwfang requested a review from ia0 as a code owner December 18, 2024 07:19
@zhouwfang

Copy link
Copy Markdown
Contributor Author

@ia0 I posted zhouwfang#5 to show the debug asserts added for val_cnt and pop_cnt with a question. Could you take a look? Thanks.

@ia0 ia0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pushing a change with my suggestions.

Comment thread crates/interpreter/src/valid.rs
Comment thread crates/interpreter/src/valid.rs Outdated
@ia0
ia0 merged commit 18bedde into google:dev/fast-interp Dec 23, 2024
@zhouwfang
zhouwfang deleted the fix-valcnt-for-if branch December 24, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants