Use instead of restoring side table for Loop#705
Merged
ia0 merged 6 commits intoDec 13, 2024
Conversation
ia0
reviewed
Dec 12, 2024
Member
|
On nordic I get:
So we should merge this PR, not only because it uses less RAM, but also because it simplifies the code. |
Contributor
Author
How do you measure RAM? |
ia0
approved these changes
Dec 13, 2024
Member
This is specific to Nordic: |
Merged
ia0
pushed a commit
that referenced
this pull request
Dec 24, 2024
It improves the performance by removing the costly `last_frame_values_cnt()`. On linux, `CoreMark result: 39.795715 (in 17.853s)`. cf. CoreMark result was about 37 in 19s in #705. #46 --------- Co-authored-by: Zhou Fang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my Linux Docker container:
CoreMark results of this PR: 37.991516 (in 18.695s), 36.7287 (in 19.258s)
CoreMark results of #690: 37.101162 (in 19.133s), 37.39716 (in 18.996s)
Look very similar. Not sure about
nordic.CoreMark results of
main: 28.791477 (in 18.09s), 28.814291 (in 17.734s)So there does seem some minor performance improvement with
delta_ipanddelta_stp.#46