Combine Label values in Frame#598
Merged
Merged
Conversation
test result: FAILED. 71 passed; 17 failed; 2 ignored; 0 measured; 0 filtered out; finished in 3.91s
failures:
block
br
br_if
br_table
call
call_indirect
fac
global
if_
labels
left_to_right
local_tee
loop_
select
switch
unreachable
unwind
ia0
reviewed
Sep 3, 2024
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
Yes, I think the overall plan looks good.
zhouwfang
commented
Sep 4, 2024
failures:
br
br_if
br_table
if_
labels
loop_
switch
unreachable
unwind
test result: FAILED. 79 passed; 9 failed; 2 ignored; 0 measured; 0 filtered out; finished in 5.16s
zhouwfang
commented
Sep 5, 2024
ia0
reviewed
Sep 5, 2024
ia0
reviewed
Sep 6, 2024
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
I'll be pushing the changes. It's faster than iterate. Feel free to try to rediscover them on your own.
ia0
approved these changes
Sep 6, 2024
ia0
added a commit
that referenced
this pull request
Sep 11, 2024
Continuation of #598 towards adding a value stack in `Thread`. #46 --------- Co-authored-by: Zhou Fang <[email protected]> Co-authored-by: Julien Cretin <[email protected]> Co-authored-by: Julien Cretin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step towards adding a value stack in
Thread. The next step is to mergelocalsandlabels_valuesinFrame. After that, we can create a value stack inThreadby combining the values from theFrame's.#46