Impl Storage#461
Merged
Merged
Conversation
kofls
marked this pull request as draft
May 9, 2024 21:08
kofls
force-pushed
the
opensk
branch
2 times, most recently
from
May 9, 2024 21:19
5614167 to
d82222d
Compare
ia0
reviewed
May 10, 2024
kofls
commented
May 17, 2024
ia0
reviewed
May 17, 2024
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
Looks mostly fine, thanks!
@kaczmarczyck can you help us with what errors are expected?
ia0
previously approved these changes
May 17, 2024
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
Thanks! LGTM, I'll commit the 2 nits and merge.
ia0
marked this pull request as ready for review
May 17, 2024 15:14
ia0
previously approved these changes
May 17, 2024
Member
|
Let's try to fix the warnings, even if it's just adding |
ia0
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.