Add skeleton for Wasefire env for OpenSK#306
Merged
Merged
Conversation
kofls
marked this pull request as draft
November 27, 2023 06:43
kofls
commented
Nov 27, 2023
ia0
reviewed
Nov 27, 2023
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
Thanks! This looks overall good to me. Let's just fix the few small details and then we can merge such that we can do incremental changes on top.
kofls
changed the title
kofls
marked this pull request as ready for review
December 1, 2023 08:41
ia0
reviewed
Dec 1, 2023
ia0
left a comment
ia0
left a comment
Member
There was a problem hiding this comment.
The toolchain is the only remaining issue. The rest can be done later.
ia0
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.