Suppress TruthSelfEquals violations in Truth.

kluever · Google Java Core Libraries · commit a43223ef586e · 2024-02-21T11:17:16.000-08:00
RELNOTES=n/a
PiperOrigin-RevId: 609061588
diff --git a/core/src/test/java/com/google/common/truth/ExpectFailureNonRuleTest.java b/core/src/test/java/com/google/common/truth/ExpectFailureNonRuleTest.java
@@ -125,6 +125,7 @@ public void ensureFailureCaught() {
     }
 
     @Test
+    @SuppressWarnings("TruthSelfEquals")
     public void testExpect_throwInSubject_shouldPropagate() {
       expectFailure.whenTesting().that(4).isEqualTo(4); // No failure being caught
       long unused = throwingMethod();
diff --git a/core/src/test/java/com/google/common/truth/ExpectFailureRuleTest.java b/core/src/test/java/com/google/common/truth/ExpectFailureRuleTest.java
@@ -38,11 +38,13 @@ public void expectFail_captureFailureAsExpected() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_passesIfUnused() {
     assertThat(4).isEqualTo(4);
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_failsAfterTest() {
     expectFailure.whenTesting().that(4).isEqualTo(4);
     thrown.expectMessage("ExpectFailure.whenTesting() invoked, but no failure was caught.");
@@ -55,6 +57,7 @@ public void expectFail_throwInSubject_shouldPropagateOriginalException() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_throwAfterSubject_shouldPropagateOriginalException() {
     expectFailure.whenTesting().that(2).isEqualTo(2);
     thrown.expectMessage("Throwing deliberately");
diff --git a/core/src/test/java/com/google/common/truth/ExpectFailureTest.java b/core/src/test/java/com/google/common/truth/ExpectFailureTest.java
@@ -54,11 +54,13 @@ public void expectFail_about() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_passesIfUnused() {
     assertThat(4).isEqualTo(4);
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_failsOnSuccess() {
     expectFailure.whenTesting().that(4).isEqualTo(4);
     try {
@@ -83,6 +85,7 @@ public void expectFail_failsOnMultipleFailures() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_failsOnMultiplewhenTestings() {
     try {
       expectFailure.whenTesting().that(4).isEqualTo(4);
@@ -108,6 +111,7 @@ public void expectFail_failsOnMultiplewhenTestings_thatFail() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_failsAfterTest() {
     try {
       expectFailure.whenTesting().that(4).isEqualTo(4);
@@ -121,6 +125,7 @@ public void expectFail_failsAfterTest() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectFail_whenTestingWithoutInContext_shouldFail() {
     ExpectFailure expectFailure = new ExpectFailure();
     try {
diff --git a/core/src/test/java/com/google/common/truth/ExpectFailureWithStackTraceTest.java b/core/src/test/java/com/google/common/truth/ExpectFailureWithStackTraceTest.java
@@ -33,6 +33,7 @@ public class ExpectFailureWithStackTraceTest {
   @Rule public final FailingExpect failToExpect = new FailingExpect();
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectTwoFailures() {
     failToExpect.delegate.that(4).isNotEqualTo(4);
     failToExpect.delegate.that("abc").contains("x");
diff --git a/core/src/test/java/com/google/common/truth/ExpectTest.java b/core/src/test/java/com/google/common/truth/ExpectTest.java
@@ -79,6 +79,7 @@ public void evaluate() throws Throwable {
       };
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void expectTrue() {
     expect.that(4).isEqualTo(4);
   }
@@ -175,6 +176,7 @@ public void expectSuccessWithFailuresAfterAssume() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void warnWhenExpectIsNotRule() {
     String message = "assertion made on Expect instance, but it's not enabled as a @Rule.";
     thrown.expectMessage(message);
diff --git a/core/src/test/java/com/google/common/truth/IntegerSubjectTest.java b/core/src/test/java/com/google/common/truth/IntegerSubjectTest.java
@@ -36,6 +36,7 @@
 public class IntegerSubjectTest extends BaseSubjectTestCase {
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void simpleEquality() {
     assertThat(4).isEqualTo(4);
   }
diff --git a/core/src/test/java/com/google/common/truth/IterableSubjectTest.java b/core/src/test/java/com/google/common/truth/IterableSubjectTest.java
@@ -709,7 +709,7 @@ public String toString() {
   }
 
   @Test
-  @SuppressWarnings("ContainsExactlyNone")
+  @SuppressWarnings({"ContainsExactlyNone", "TruthSelfEquals"})
   public void iterableContainsExactlyElementsInInOrderPassesWithEmptyExpectedAndActual() {
     assertThat(ImmutableList.of()).containsExactlyElementsIn(ImmutableList.of()).inOrder();
   }
diff --git a/core/src/test/java/com/google/common/truth/LongSubjectTest.java b/core/src/test/java/com/google/common/truth/LongSubjectTest.java
@@ -36,6 +36,7 @@
 public class LongSubjectTest extends BaseSubjectTestCase {
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void simpleEquality() {
     assertThat(4L).isEqualTo(4L);
   }
diff --git a/core/src/test/java/com/google/common/truth/NumericComparisonTest.java b/core/src/test/java/com/google/common/truth/NumericComparisonTest.java
@@ -73,6 +73,7 @@ public void testPrimitivesVsBoxedPrimitivesVsObject_long() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void testAllCombinations_pass() {
     assertThat(42).isEqualTo(42L);
     assertThat(42).isEqualTo(Long.valueOf(42L));
diff --git a/core/src/test/java/com/google/common/truth/StringSubjectTest.java b/core/src/test/java/com/google/common/truth/StringSubjectTest.java
@@ -128,6 +128,7 @@ public void stringDoesNotContainFail() {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void stringEquality() {
     assertThat("abc").isEqualTo("abc");
   }
diff --git a/core/src/test/java/com/google/common/truth/gwt/TruthGwtTest.java b/core/src/test/java/com/google/common/truth/gwt/TruthGwtTest.java
@@ -52,6 +52,7 @@ public void testBoolean() {
     }
   }
 
+  @SuppressWarnings("TruthSelfEquals")
   public void testInteger() {
     assertThat(457923).isEqualTo(457923);
     try {
diff --git a/extensions/java8/src/test/java/com/google/common/truth/IntStreamSubjectTest.java b/extensions/java8/src/test/java/com/google/common/truth/IntStreamSubjectTest.java
@@ -36,6 +36,7 @@
 public final class IntStreamSubjectTest {
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void testIsEqualTo() throws Exception {
     IntStream stream = IntStream.of(42);
     Truth8.assertThat(stream).isEqualTo(stream);
@@ -65,6 +66,7 @@ public void testNullStreamIsNull() throws Exception {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void testIsSameInstanceAs() throws Exception {
     IntStream stream = IntStream.of(1);
     Truth8.assertThat(stream).isSameInstanceAs(stream);
diff --git a/extensions/java8/src/test/java/com/google/common/truth/LongStreamSubjectTest.java b/extensions/java8/src/test/java/com/google/common/truth/LongStreamSubjectTest.java
@@ -36,6 +36,7 @@
 public final class LongStreamSubjectTest {
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void testIsEqualTo() throws Exception {
     LongStream stream = LongStream.of(42);
     Truth8.assertThat(stream).isEqualTo(stream);
@@ -65,6 +66,7 @@ public void testNullStreamIsNull() throws Exception {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void testIsSameInstanceAs() throws Exception {
     LongStream stream = LongStream.of(1);
     Truth8.assertThat(stream).isSameInstanceAs(stream);
diff --git a/extensions/java8/src/test/java/com/google/common/truth/StreamSubjectTest.java b/extensions/java8/src/test/java/com/google/common/truth/StreamSubjectTest.java
@@ -37,15 +37,15 @@
 @RunWith(JUnit4.class)
 public final class StreamSubjectTest {
 
-  @SuppressWarnings("deprecation") // test of a possibly mistaken call
+  @SuppressWarnings({"deprecation", "TruthSelfEquals"}) // test of a possibly mistaken call
   @Test
   public void testIsEqualToSameInstancePreviouslyConsumed() throws Exception {
     Stream<String> stream = Stream.of("hello");
     stream.forEach(e -> {}); // Consume it so that we can verify that isEqualTo still works
     assertThat(stream).isEqualTo(stream);
   }
 
-  @SuppressWarnings("deprecation") // test of a possibly mistaken call
+  @SuppressWarnings({"deprecation", "TruthSelfEquals"}) // test of a possibly mistaken call
   @Test
   public void testIsEqualToSameInstanceDoesNotConsume() throws Exception {
     Stream<String> stream = Stream.of("hello");
@@ -124,6 +124,7 @@ public void testNullStreamIsNull() throws Exception {
   }
 
   @Test
+  @SuppressWarnings("TruthSelfEquals")
   public void testIsSameInstanceAs() throws Exception {
     Stream<String> stream = Stream.of("hello");
     assertThat(stream).isSameInstanceAs(stream);

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ public void ensureFailureCaught() {`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`@Test`
	`128`	`+ @SuppressWarnings("TruthSelfEquals")`
`128`	`129`	`public void testExpect_throwInSubject_shouldPropagate() {`
`129`	`130`	`expectFailure.whenTesting().that(4).isEqualTo(4); // No failure being caught`
`130`	`131`	`long unused = throwingMethod();`
Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,13 @@ public void expectFail_captureFailureAsExpected() {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`@Test`
	`41`	`+ @SuppressWarnings("TruthSelfEquals")`
`41`	`42`	`public void expectFail_passesIfUnused() {`
`42`	`43`	`assertThat(4).isEqualTo(4);`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`@Test`
	`47`	`+ @SuppressWarnings("TruthSelfEquals")`
`46`	`48`	`public void expectFail_failsAfterTest() {`
`47`	`49`	`expectFailure.whenTesting().that(4).isEqualTo(4);`
`48`	`50`	`thrown.expectMessage("ExpectFailure.whenTesting() invoked, but no failure was caught.");`
`@@ -55,6 +57,7 @@ public void expectFail_throwInSubject_shouldPropagateOriginalException() {`
`55`	`57`	`}`
`56`	`58`
`57`	`59`	`@Test`
	`60`	`+ @SuppressWarnings("TruthSelfEquals")`
`58`	`61`	`public void expectFail_throwAfterSubject_shouldPropagateOriginalException() {`
`59`	`62`	`expectFailure.whenTesting().that(2).isEqualTo(2);`
`60`	`63`	`thrown.expectMessage("Throwing deliberately");`
Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ public void evaluate() throws Throwable {`
`79`	`79`	`};`
`80`	`80`
`81`	`81`	`@Test`
	`82`	`+ @SuppressWarnings("TruthSelfEquals")`
`82`	`83`	`public void expectTrue() {`
`83`	`84`	`expect.that(4).isEqualTo(4);`
`84`	`85`	`}`
`@@ -175,6 +176,7 @@ public void expectSuccessWithFailuresAfterAssume() {`
`175`	`176`	`}`
`176`	`177`
`177`	`178`	`@Test`
	`179`	`+ @SuppressWarnings("TruthSelfEquals")`
`178`	`180`	`public void warnWhenExpectIsNotRule() {`
`179`	`181`	`String message = "assertion made on Expect instance, but it's not enabled as a @Rule.";`
`180`	`182`	`thrown.expectMessage(message);`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@`
`36`	`36`	`public class IntegerSubjectTest extends BaseSubjectTestCase {`
`37`	`37`
`38`	`38`	`@Test`
	`39`	`+ @SuppressWarnings("TruthSelfEquals")`
`39`	`40`	`public void simpleEquality() {`
`40`	`41`	`assertThat(4).isEqualTo(4);`
`41`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,7 @@ public String toString() {`
`709`	`709`	`}`
`710`	`710`
`711`	`711`	`@Test`
`712`		`- @SuppressWarnings("ContainsExactlyNone")`
	`712`	`+ @SuppressWarnings({"ContainsExactlyNone", "TruthSelfEquals"})`
`713`	`713`	`public void iterableContainsExactlyElementsInInOrderPassesWithEmptyExpectedAndActual() {`
`714`	`714`	`assertThat(ImmutableList.of()).containsExactlyElementsIn(ImmutableList.of()).inOrder();`
`715`	`715`	`}`
Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@ public void testPrimitivesVsBoxedPrimitivesVsObject_long() {`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`@Test`
	`76`	`+ @SuppressWarnings("TruthSelfEquals")`
`76`	`77`	`public void testAllCombinations_pass() {`
`77`	`78`	`assertThat(42).isEqualTo(42L);`
`78`	`79`	`assertThat(42).isEqualTo(Long.valueOf(42L));`
Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ public void stringDoesNotContainFail() {`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`@Test`
	`131`	`+ @SuppressWarnings("TruthSelfEquals")`
`131`	`132`	`public void stringEquality() {`
`132`	`133`	`assertThat("abc").isEqualTo("abc");`
`133`	`134`	`}`