Skip to content

Update stop_name Best Practices#282

Merged
sccmcca merged 3 commits intogoogle:masterfrom
MobilityData:stop-name-bp
Sep 13, 2021
Merged

Update stop_name Best Practices#282
sccmcca merged 3 commits intogoogle:masterfrom
MobilityData:stop-name-bp

Conversation

@sccmcca
Copy link
Copy Markdown
Contributor

@sccmcca sccmcca commented Aug 26, 2021

As flagged in #273 and #281 by @flocsy: proposal to disambiguate stop_name best practices to reflect actual published naming conventions and handling translations for local/foreign riders in translations.txt.

@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@sccmcca sccmcca linked an issue Aug 26, 2021 that may be closed by this pull request
@mgilligan
Copy link
Copy Markdown

+1, TriMet

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Aug 26, 2021

+1 (OpenGeo)

@flocsy
Copy link
Copy Markdown
Contributor

flocsy commented Aug 29, 2021

+1 Moovit

@sccmcca sccmcca added the GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule label Aug 30, 2021
@sccmcca
Copy link
Copy Markdown
Contributor Author

sccmcca commented Sep 3, 2021

Now that 7 days of discussion have passed, we can call an official vote (@mgilligan, @skinkie, @flocsy thanks for the enthusiasm, feel free to recast your votes!). This vote is for updating the stop_name best practices as outlined in this PR.

Voting ends on 2021-09-10 at 23:59:59 UTC.

Thanks!

@sccmcca sccmcca added the Vote to Test Community votes to determine whether the proposal is ready for testing. label Sep 3, 2021
@gcamp
Copy link
Copy Markdown
Contributor

gcamp commented Sep 3, 2021

+1 Transit

@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Sep 3, 2021

Still voting +1 (OpenGeo)!

scott christian mccallum added 2 commits September 3, 2021 08:54
editorial: reverting an error caused by resolving conflicts
@brodyFlannigan
Copy link
Copy Markdown

+1 Brody Flannigan Transit Data on behalf of Transcollines.

@jspetrak
Copy link
Copy Markdown

jspetrak commented Sep 3, 2021

+1 from Bileto

@paulswartz
Copy link
Copy Markdown
Contributor

+1 from @mbta

@mgilligan
Copy link
Copy Markdown

+1, TriMet again

@antrim
Copy link
Copy Markdown
Contributor

antrim commented Sep 3, 2021

+1 from Trillium

@flocsy
Copy link
Copy Markdown
Contributor

flocsy commented Sep 5, 2021

+1 Moovit

@darylweinberg
Copy link
Copy Markdown

darylweinberg commented Sep 7, 2021 via email

@Bertware
Copy link
Copy Markdown

Bertware commented Sep 9, 2021

+1 Samtrafiken/Trafiklab

@abyrd
Copy link
Copy Markdown

abyrd commented Sep 10, 2021

+1 Conveyal

@sccmcca
Copy link
Copy Markdown
Contributor Author

sccmcca commented Sep 13, 2021

The vote ended on 2021-09-10 at 23:59:59 UTC with 11 votes in favor and 0 opposed. As per the Specification Amendment Process, this vote passes!

Thanks to all involved.

@sccmcca sccmcca merged commit a24a32f into google:master Sep 13, 2021
@sccmcca sccmcca removed the Vote to Test Community votes to determine whether the proposal is ready for testing. label Sep 13, 2021
@doconnoronca
Copy link
Copy Markdown
Contributor

Should something to mentioned about mixed case vs all caps?

@sccmcca
Copy link
Copy Markdown
Contributor Author

sccmcca commented Sep 16, 2021

@doconnoronca We can add in a following sentence:

Provide stop names in mixed case, following local conventions, as per recommendation for all rider-facing text fields.

What do you think?

@gcamp
Copy link
Copy Markdown
Contributor

gcamp commented Sep 16, 2021

That mention should be general to any string, not just stop name.

@barbeau
Copy link
Copy Markdown
Contributor

barbeau commented Sep 16, 2021

http://gtfs.org/best-practices/#all-files says:

All customer-facing text strings (including stop names, route names, and headsigns) should use Mixed Case (not ALL CAPS), following local conventions for capitalization of place names on displays capable of displaying lower case characters.

@doconnoronca
Copy link
Copy Markdown
Contributor

Mixed case is already mentioned elsewhere then it is not needed here.

Often stop names are the names of two cross streets. It would be beneficial if they are seperated by a consistent seperater across the whole file, whether it be " and ", " + ", "/" or whatever. Also the street the vehicle is traveling on should be first and the cross street second.

@sccmcca
Copy link
Copy Markdown
Contributor Author

sccmcca commented Sep 16, 2021

@doconnoronca Would recommending a consistent separator for cross streets be at odds with:

The stop_name should match the agency's rider-facing name for the location as printed on a timetable, published online, or represented on signage.

? For example if one agency has a timetable that publishes " and " and another agency has a timetable that publishes " / ". Technically they are following the spec recommendation to match their data to their official material, albeit using different ways to describe cross streets.

@doconnoronca
Copy link
Copy Markdown
Contributor

It's where one agency uses 3 or 4 different seperators in one stops.txt file.

@sccmcca
Copy link
Copy Markdown
Contributor Author

sccmcca commented Sep 16, 2021

I see! Maybe something like:

Stops named after cross streets should separate street names by a single consistent separator within stops.txt (e.g., "at", "and", "&", "/"). The first street name should be the street that the vehicle is travelling on at the time of the stop, and the second street name should be the cross street (i.e., < first street name > < separator > < second street name >).

@brodyFlannigan
Copy link
Copy Markdown

I see! Maybe something like:

Stops named after cross streets should separate street names by a single consistent separator within stops.txt (e.g., "at", "and", "&", "/"). The first street name should be the street that the vehicle is travelling on at the time of the stop, and the second street name should be the cross street (i.e., < first street name > < separator > < second street name >).

I love this. I've seen some feeds with 3 or even 4 different seperators and totally inconsitent stop names so this is a huge +1 for me.

@doconnoronca
Copy link
Copy Markdown
Contributor

Looks good.

@flocsy
Copy link
Copy Markdown
Contributor

flocsy commented Sep 19, 2021

maybe it would be wise to create a new PR for the separator discussion, as this PR's vote already finished

@sccmcca
Copy link
Copy Markdown
Contributor Author

sccmcca commented Sep 20, 2021

@flocsy I agree. Please see #285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tourist's needs