Re-enable RTTI (needed in order to subclass Source, etc.)#144
Closed
tserong wants to merge 1 commit intogoogle:masterfrom
Closed
Re-enable RTTI (needed in order to subclass Source, etc.)#144tserong wants to merge 1 commit intogoogle:masterfrom
tserong wants to merge 1 commit intogoogle:masterfrom
Conversation
Commit c98344f in snappy 1.1.9 disabled RTTI, which means the snappy library no longer exports typeinfo for snappy::Source, snappy::Sink, ..., so users of the library can't subclass these classes anymore. Here's a trivial reproducer: #include <snappy-sinksource.h> class MySource : snappy::Source { public: size_t Available() const override { return 0; } const char *Peek(size_t *len) override { return NULL; } void Skip(size_t n) override {} }; int main(int argc, char **argv) { MySource m; return 0; } Try `g++ -o snappy-test ./snappy-test.cc -lsnappy` with the above and the linker will fail with "undefined reference to `typeinfo for snappy::Source'" if RTTI was disabled in the snappy build.
Member
|
Sorry, I am not going to accept this PR. The current CMake configuration reflects the supported build setup for this library, and what runs in CI. RTTI is disabled in Google Chrome, which is the largest testing vehicle for Snappy. |
Author
|
Would you mind bumping the soname version then, as disabling RTTI breaks the ABI? A similar issue was raised against leveldb (google/leveldb#927) |
4 tasks
clrpackages
pushed a commit
to clearlinux-pkgs/snappy
that referenced
this pull request
Apr 7, 2022
This patch addresses an issue with Ceph https://tracker.ceph.com/issues/53060. There have been multiple patches to upstream snappy, but they have all been rejected and the reasoning has always been that snappy would like to be consistent in their build flags with chrome as mentioned at google/snappy#144 (comment)
This was referenced Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit c98344f in snappy 1.1.9 disabled RTTI, which means the snappy library no longer exports typeinfo for snappy::Source, snappy::Sink, ..., so users of the library can't subclass these classes anymore.
Here's a trivial reproducer:
Try
g++ -o snappy-test ./snappy-test.cc -lsnappywith the above and the linker will fail with "undefined reference to `typeinfo for snappy::Source'" if RTTI was disabled in the snappy build.