Repository navigation
Commit c5f9953
[skparagraph] Count only soft hyphens when measuring too-long words
https://skia-review.googlesource.com/c/skia/+/1398738 made the
too-long-word check in TextWrapper::lookAhead count the width of the
cluster at a soft break before stopping, so that a letter-spaced soft
hyphen counts. That applied to every other soft break too, including
the end of the text, so a too-long word at the end of a paragraph is
now split on the current line instead of first moving to the next line.
That broke a Flutter test (DropdownMenuEntries do not overflow when
width is specified) and the Skia rolls into Flutter
(flutter/flutter#195089,
flutter/flutter#195098).
Count the cluster only when it's a soft hyphen. Other soft breaks again
end the word before their cluster, as before 1398738.
[email protected], [email protected]
Bug: flutter/flutter#194582
Change-Id: Ied1e5b3b0be915952fac798002d57fba972fb5ae
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1403136
Reviewed-by: Julia Lavrova <[email protected]>
Commit-Queue: Julia Lavrova <[email protected]>
Reviewed-by: Brandon Wilson <[email protected]>1 parent 93bf31b commit c5f9953
2 files changed
Lines changed: 34 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
147 | 152 | | |
148 | 153 | | |
149 | 154 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11155 | 11155 | | |
11156 | 11156 | | |
11157 | 11157 | | |
| 11158 | + | |
| 11159 | + | |
| 11160 | + | |
| 11161 | + | |
| 11162 | + | |
| 11163 | + | |
| 11164 | + | |
| 11165 | + | |
| 11166 | + | |
| 11167 | + | |
| 11168 | + | |
| 11169 | + | |
| 11170 | + | |
| 11171 | + | |
| 11172 | + | |
| 11173 | + | |
| 11174 | + | |
| 11175 | + | |
| 11176 | + | |
| 11177 | + | |
| 11178 | + | |
| 11179 | + | |
| 11180 | + | |
| 11181 | + | |
| 11182 | + | |
| 11183 | + | |
| 11184 | + | |
| 11185 | + | |
| 11186 | + | |
11158 | 11187 | | |
11159 | 11188 | | |
11160 | 11189 | | |
| |||
0 commit comments