Skip to content

Ensure domain sent for reporting is consistent #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 2 commits into from
Jun 26, 2019
Merged

Ensure domain sent for reporting is consistent #22

felixarntz merged 2 commits into from
Jun 26, 2019

Conversation

@adamsilverstein
Copy link
Contributor

@adamsilverstein adamsilverstein commented Jun 21, 2019 •
edited by felixarntz
Loading

Summary

This PR can be summarized in the following changelog entry:

  • Ensure domain sent for reporting is consistent by trimming any trailing slashes.

Fixes #23

Relevant technical choices

Checklist:

ivankristianto
ivankristianto approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@ivankristianto ivankristianto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felixarntz felixarntz added Type: Bug Something isn't working P1 Medium priority labels Jun 25, 2019
@felixarntz felixarntz added this to the 1.0.0-beta.1.1 milestone Jun 25, 2019
felixarntz
felixarntz approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@felixarntz felixarntz merged commit 5d030d0 into develop Jun 26, 2019
@felixarntz felixarntz removed Type: Bug Something isn't working P1 Medium priority P0 High priority labels Jun 27, 2019
@felixarntz felixarntz removed this from the 1.0.0-beta.1.1 milestone Jun 27, 2019
@felixarntz felixarntz deleted the fix/normalize-urls-for-reporting branch July 4, 2019 11:34
@yescit yescit mentioned this pull request Aug 7, 2023
Closed
github-actions bot pushed a commit to benbowler/site-kit-wp that referenced this pull request Jun 18, 2025
@actions-user
Update E2E stability test results (run google#22) [skip ci]
ae6af5e
github-actions bot pushed a commit to benbowler/site-kit-wp that referenced this pull request Jun 19, 2025
@actions-user
Update backstop stability test results (run google#22) [skip ci]
230269b
@jamesozzie jamesozzie mentioned this pull request Jul 4, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixarntz felixarntz felixarntz approved these changes

+1 more reviewer

@ivankristianto ivankristianto ivankristianto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Domain used for reporting is not consistent, resulting in duplicates

3 participants

@adamsilverstein @ivankristianto @felixarntz